[ 
https://issues.apache.org/jira/browse/CALCITE-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418351#comment-15418351
 ] 

Josh Elser commented on CALCITE-1350:
-------------------------------------

Right you are as always, Julian. Lost messages between client and server are 
definitely a concern. There's a bit of digging implicit in this one -- I just 
wanted to make sure I did not forget about the idea when I have a chance to 
look into this.

Worst case, we might saturate the server with open JDBC connections if we 
incorrectly thought the server never opened them. However, this is tempered 
already by the eviction of connections that are not used within 10mins (by 
default). This would have to be a rare case to be acceptable.

Consideration/thought definitely required.

> Avoid closeConnection when openConnection doesn't finish/succeed
> ----------------------------------------------------------------
>
>                 Key: CALCITE-1350
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1350
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: avatica-1.9.0
>
>
> I've noticed during testing of Avatica, often times when SPNEGO 
> authentication is misconfigured, the client will get stuck in 
> openConnection().
> If we consider sqlline and the user control-C's it, sqlline will try to close 
> the driver as well which would do a closeConnection() (which would also 
> obviously fail).
> I believe we should be able to short-circuit the the closeConnection() when 
> we know that the openConnection() didn't succeed properly.
> Another scenario is when the Avatica server is down. openConnection will 
> fail, but we'll still attempt the closeConnection on exit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to