[
https://issues.apache.org/jira/browse/CALCITE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435398#comment-15435398
]
Josh Elser commented on CALCITE-1301:
-------------------------------------
bq. Yup. Looks great. Thanks!
Actually, it looks like {{flagMap}} is never cleaned up. Is this not a concern?
> Add cancel flag to AvaticaResultSet
> -----------------------------------
>
> Key: CALCITE-1301
> URL: https://issues.apache.org/jira/browse/CALCITE-1301
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
> Labels: avatica
> Fix For: avatica-1.9.0
>
>
> Add cancel flag to AvaticaResultSet. The flag was added to CalciteResultSet
> as part of CALCITE-1227, but would be useful in the Avatica base class.
> It is currently of type {{CancelFlag}} but maybe it should become
> {{AtomicBoolean}}.
> To complete implementation of java.sql.Statement#cancel we would need a
> Cancel command; that is out of scope of this case, and would be covered by
> CALCITE-520.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
