[
https://issues.apache.org/jira/browse/CALCITE-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437090#comment-15437090
]
Julian Hyde commented on CALCITE-1290:
--------------------------------------
Looks good. I changed a logic a bit so that any negative number means no
threshold (previously, Integer.MAX_VALUE meant no threshold). Will commit when
my tests have passed.
> When converting to CNF, fail if the expression exceeds a threshold
> ------------------------------------------------------------------
>
> Key: CALCITE-1290
> URL: https://issues.apache.org/jira/browse/CALCITE-1290
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Jesus Camacho Rodriguez
>
> When converting to conjunctive normal form (CNF), fail if the expression
> exceeds a threshold. CNF can explode exponentially in the size of the input
> expression, but rarely does so in practice. Add a {{maxNodeCount}} parameter
> to {{RexUtil.toCnf}} and throw or return null if it is exceeded.
> I don't believe it is possible to predict the size of the CNF from the input
> expression (especially if there are duplicate terms) but I might be wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
