[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468885#comment-15468885
]
Julian Hyde commented on CALCITE-1342:
--------------------------------------
[~minjikim], I saw you modified the arguments to
{{RelOptUtil.createProject(RelNode, List, List, boolean, ProjectFactory)}} and
was going to suggest that retain a deprecated copy of that method. But then I
saw that [~jcamachorodriguez] only recently created the method, in CALCITE-826.
So we're good.
I believe that {{RelOptUtil.createProject(RelNode, List, boolean,
ProjectFactory)}} is not used, and it has not been released. Can you remove it?
After that, +1. Can you please commit and push to Apache master?
* Be sure to add a 'Close apache/calcite#NNN' line, to automatically close the
PR.
* Don't add ' (MinJi Kim)' at the end of the message - we only do that for
non-committers.
* Please mark this case resolved, and fixed in 1.9.0, after you commit.
> ProjectPusher should use rel factories when creating new rels, e.g.
> project/filter
> ----------------------------------------------------------------------------------
>
> Key: CALCITE-1342
> URL: https://issues.apache.org/jira/browse/CALCITE-1342
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: MinJi Kim
> Assignee: Julian Hyde
>
> I was playing around with some new ideas in drill, and wanted to use
> ProjectPusher, which has a lot of useful utility functions. ProjectPusher
> returns new nodes, but they are LogicalProjects/LogicalFilters. It would be
> more useful if the user of ProjectPusher could specify the rel factories to
> use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
