Maryann Xue commented on CALCITE-1431:

Thank you very much for the review, [~julianhyde]! I should definitely use 
type.getFieldNames(), but when change to {{ignoreNullable ? something(type) : 
RelOptUtil.getFieldTypeList(type)}}, I got a lot of test failures. Then I 
notice the comment right above "return createStructType(":
    // REVIEW: angel 18-Aug-2005 dtbug336
    // Shouldn't null refer to the nullability of the record type
    // not the individual field types?
    // For flattening and outer joins, it is desirable to change
    // the nullability of the individual fields.
I guess that was the reason why the test cases failed.

> RelDataTypeFactoryImpl.copyType() did not copy StructKind
> ---------------------------------------------------------
>                 Key: CALCITE-1431
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1431
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>            Priority: Minor
>              Labels: phoenix
>             Fix For: 1.11.0
> Now that StructKind has been introduced as an attribute of RelDataType by 
> CALCITE-1208, when copying a RecordType, we should also copy its StructKind.
> This would be an issue in view expansion, in which columns could not be 
> resolved from a view the same way as they would from its original table. 

This message was sent by Atlassian JIRA

Reply via email to