[ 
https://issues.apache.org/jira/browse/CALCITE-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576994#comment-15576994
 ] 

Julian Hyde commented on CALCITE-1442:
--------------------------------------

I'm not surprised at all that there's no existing test. Having spent the day 
studying this code, you probably know more about it than anyone else in the 
world, so you are in a good position to write a few tests. :)

> SqlIntervalQualifer#getFractionalSecondPrecisionPreservingDefault() returns 
> the wrong field
> -------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1442
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1442
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Laurent Goujon
>            Assignee: Julian Hyde
>            Priority: Minor
>
> Unless I'm wrong, I believe 
> {{SqlIntervalQualifer#getFractionalSecondPrecisionPreservingDefault()}} 
> returns the wrong field:
> {code:java}
>   public int getFractionalSecondPrecision(RelDataTypeSystem typeSystem) {
>     if (fractionalSecondPrecision == RelDataType.PRECISION_NOT_SPECIFIED) {
>       return typeName().getDefaultScale();
>     } else {
>       return fractionalSecondPrecision;
>     }
>   }
>   public int getFractionalSecondPrecisionPreservingDefault() {
>     if (useDefaultFractionalSecondPrecision()) {
>       return RelDataType.PRECISION_NOT_SPECIFIED;
>     } else {
>       return startPrecision;
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to