[ 
https://issues.apache.org/jira/browse/CALCITE-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577033#comment-15577033
 ] 

Laurent Goujon edited comment on CALCITE-1442 at 10/15/16 12:51 AM:
--------------------------------------------------------------------

if you mean "debugging what the value was not the one I was expecting in Drill, 
and clicking on call hierarchy on my IDE to see where this function was used", 
yes I deeply studied the code :) and the code is present from the early days I 
guess (if I'm correct, introduced in commit 
b0dab683059fa1163dc95cb9ea7540ad6a4968ab)


was (Author: laurentgo):
if you mean "debugging what the value was not the one I was expecting in 
Dremio, and clicking on call hierarchy on my IDE to see where this function was 
used", yes I deeply studied the code :) and the code is present from the early 
days I guess (if I'm correct, introduced in commit 
b0dab683059fa1163dc95cb9ea7540ad6a4968ab)

> SqlIntervalQualifer#getFractionalSecondPrecisionPreservingDefault() returns 
> the wrong field
> -------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1442
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1442
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Laurent Goujon
>            Assignee: Julian Hyde
>            Priority: Minor
>
> Unless I'm wrong, I believe 
> {{SqlIntervalQualifer#getFractionalSecondPrecisionPreservingDefault()}} 
> returns the wrong field:
> {code:java}
>   public int getFractionalSecondPrecision(RelDataTypeSystem typeSystem) {
>     if (fractionalSecondPrecision == RelDataType.PRECISION_NOT_SPECIFIED) {
>       return typeName().getDefaultScale();
>     } else {
>       return fractionalSecondPrecision;
>     }
>   }
>   public int getFractionalSecondPrecisionPreservingDefault() {
>     if (useDefaultFractionalSecondPrecision()) {
>       return RelDataType.PRECISION_NOT_SPECIFIED;
>     } else {
>       return startPrecision;
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to