[ 
https://issues.apache.org/jira/browse/CALCITE-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587649#comment-15587649
 ] 

Julian Hyde commented on CALCITE-1430:
--------------------------------------

It's OK, the existing test cases will do. (I saw you added a test case for 
CALCITE-1429. I think you meant to put your "Updated! Please review it" comment 
on that case.)

> In Druid adapter, "pagingIdentifiers" might have more than one value
> --------------------------------------------------------------------
>
>                 Key: CALCITE-1430
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1430
>             Project: Calcite
>          Issue Type: Bug
>          Components: druid
>            Reporter: Jiarong Wei
>            Assignee: Julian Hyde
>             Fix For: 1.11.0
>
>
> When {{segmentGranularity}} is coarse, all data may be fit into just one 
> segment. But 
> [it|https://github.com/apache/calcite/blob/master/druid/src/main/java/org/apache/calcite/adapter/druid/DruidConnectionImpl.java#L192]
>  should not assume there's only one segment. So {{pagingIdentifiers}} may 
> have more than one value.
> Here is a typical error stack:
> {noformat}
> java.lang.RuntimeException: expected END_OBJECT, got FIELD_NAME
>       at 
> org.apache.calcite.adapter.druid.DruidConnectionImpl.expect(DruidConnectionImpl.java:330)
>       at 
> org.apache.calcite.adapter.druid.DruidConnectionImpl.parse(DruidConnectionImpl.java:195)
>       at 
> org.apache.calcite.adapter.druid.DruidConnectionImpl.request(DruidConnectionImpl.java:103)
>       at 
> org.apache.calcite.adapter.druid.DruidQuery$DruidQueryNode.run(DruidQuery.java:936)
>       at 
> org.apache.calcite.interpreter.Interpreter.start(Interpreter.java:114)
>       at 
> org.apache.calcite.interpreter.Interpreter.enumerator(Interpreter.java:92)
>       at 
> org.apache.calcite.linq4j.EnumerableDefaults$15$1.<init>(EnumerableDefaults.java:1890)
>       at 
> org.apache.calcite.linq4j.EnumerableDefaults$15.enumerator(EnumerableDefaults.java:1889)
>       at 
> org.apache.calcite.linq4j.AbstractEnumerable.iterator(AbstractEnumerable.java:33)
>       at org.apache.calcite.avatica.MetaImpl.createCursor(MetaImpl.java:77)
>       at 
> org.apache.calcite.avatica.AvaticaResultSet.execute(AvaticaResultSet.java:190)
>       at 
> org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.java:77)
>       at 
> org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.java:49)
>       at 
> org.apache.calcite.avatica.AvaticaConnection$1.execute(AvaticaConnection.java:605)
> {noformat}
> PRs:
> * https://github.com/apache/calcite/pull/302
> * https://github.com/vlsi/calcite-test-dataset/pull/14



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to