[ https://issues.apache.org/jira/browse/CALCITE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Hyde updated CALCITE-1461: --------------------------------- Summary: Hard coded class name in JaninoRelMetadataProvider breaks shading (was: Hard code in JaninoRelMetadataProvider makes shading for Calcite failed) > Hard coded class name in JaninoRelMetadataProvider breaks shading > ----------------------------------------------------------------- > > Key: CALCITE-1461 > URL: https://issues.apache.org/jira/browse/CALCITE-1461 > Project: Calcite > Issue Type: Bug > Reporter: Jark Wu > Assignee: Julian Hyde > > In {{JaninoRelMetadataProvider.load3}}, the generated class string contains > some hard coded Calcite's classes, such as > {{org.apache.calcite.rel.metadata.MetadataDef}}. After shading Calcite, the > MetadataDef can not be found in the shaded classes. And a compile error will > be thrown. > So it's better to use {{MetadataDef.class.getName()}} to replace the hard > code string. > I'm appreciate to make a PR if you want. -- This message was sent by Atlassian JIRA (v6.3.4#6332)