[ 
https://issues.apache.org/jira/browse/CALCITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde reassigned CALCITE-1353:
------------------------------------

    Assignee: Francis Chuang

[~francischuang], Hope you don't mind; I've assigned this to you, so that we 
can get it into avatica-1.10. Maybe [~elserj] can help you devise a 
backwards-compatible way to change the protocol.

> first_frame_max_size in an ExecuteRequest should be an int32 in protobuf 
> definitions.
> -------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1353
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1353
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>    Affects Versions: avatica-1.8.0
>            Reporter: Francis Chuang
>            Assignee: Francis Chuang
>            Priority: Minor
>             Fix For: avatica-1.10.0
>
>
> In the protobuf definition for {{ExecuteRequest}}, the 
> {{first_frame_max_size}} parameter is typed as an {{uint64}}. See 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130.
>  For consistency, it should be an {{int32}}.
> Similar parameters relating to the frame size are all typed as {{int32}}.
> For a {{PrepareAndExecuteRequest}}, {{first_frame_max_size}} is a{{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78
> For a {{FetchRequest}}, {{frame_max_size}} is a {{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to