[ 
https://issues.apache.org/jira/browse/CALCITE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde updated CALCITE-973:
--------------------------------
    Component/s: jdbc-adapter

> Implement INSERT in JDBC adapter (JdbcTableModify)
> --------------------------------------------------
>
>                 Key: CALCITE-973
>                 URL: https://issues.apache.org/jira/browse/CALCITE-973
>             Project: Calcite
>          Issue Type: Bug
>          Components: jdbc-adapter
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> JdbcTableModify is not implemented.
> In fact the current implementation was copied quickly and without much 
> thought from EnumerableTableModify and is a red herring. For example,  the 
> “assert table.unwrap(ModifiableTable.class) != null” logic is totally bogus.
> We should simply generate “INSERT INTO schema.table <<query>>” where 
> <<query>> is obtained by converting the input RelNode into SQL. Maybe a 
> column list would help: "INSERT INTO schema.table (c1, c2, ...) <<query>>"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to