[ https://issues.apache.org/jira/browse/CALCITE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729294#comment-15729294 ]
Christian Tzolov commented on CALCITE-1527: ------------------------------------------- Nice! Looks like you've replaced {{visit(Values e)}} by the {{convertValues(e)}} one. Is the conversion of {{INSERT...VALUES}} into {{INSERT (SELECT vx As Cx...)}} case dropped? I guess in {{RelToSqlConverter}} the line {{((SqlSelect) input.node).getWhere()}} should be {{input.asStatement()}} instead? > Support DML in the JDBC adapter > ------------------------------- > > Key: CALCITE-1527 > URL: https://issues.apache.org/jira/browse/CALCITE-1527 > Project: Calcite > Issue Type: Bug > Components: jdbc-adapter > Reporter: Christian Tzolov > Assignee: Julian Hyde > > Currently the JDBC adapter does not support the DML operations: *INSERT*, > *DELETE* and *UPDATE*. > Solution needs to convert the parsed *Modify* and *Values* RelNodes into > *JdbcTableModify*, *JdbcValues* ... such and then in turn into corresponding > SqlInsert, SqlUpdate and SqlDelete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)