[ 
https://issues.apache.org/jira/browse/CALCITE-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733717#comment-15733717
 ] 

Julian Hyde edited comment on CALCITE-1534 at 12/8/16 11:29 PM:
----------------------------------------------------------------

* When creating the SqlNodeList make sure that the position
  covers the first element to the last element. Or maybe change
  {{SqlNodeList CompoundIdentifierCommaList()}} to
 {{void CompoundIdentifierCommaList(List<SqlNode)}}
  and don't worry about the position of the list as a whole.
* Let's have a negative test inserting into a column that is not compound.
* Let's have a negative test where c0.c1 occurs more than once.


was (Author: julianhyde):
* When creating the SqlNodeList make sure that the position covers the first 
element to the last element. Or maybe change {{SqlNodeList 
CompoundIdentifierCommaList() }} to {{void 
CompoundIdentifierCommaList(List<SqlNode)}} and don't worry about the position 
of the list as a whole.
* Let's have a negative test inserting into a column that is not compound.
* Let's have a negative test where c0.c1 occurs more than once.

> Allow compound identifiers in INSERT target column list
> -------------------------------------------------------
>
>                 Key: CALCITE-1534
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1534
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.10.0
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>            Priority: Minor
>              Labels: parser, phoenix
>
> Since CALCITE-1425, the assumption of column names always being simple 
> qualifiers in INSERT/UPDATE target column list has been removed, which means 
> SqlValidator and Sql2RelConverter can handle compound identifiers in those 
> places. Right now we are going to add parser support for compound identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to