[ 
https://issues.apache.org/jira/browse/CALCITE-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755670#comment-15755670
 ] 

Julian Hyde commented on CALCITE-1540:
--------------------------------------

The easiest way to add a test is to edit {{winagg.iq}}, which is run as part of 
QuidemTest.

Quidem has a new {{!verify}} command (see 
https://github.com/julianhyde/quidem#verify) but you can't us it in this case 
because hsqldb doesn't support OVER.

Code change looks mostly good. Can you fix formatting to make checkstyle happy, 
and I see that one method now has two javadoc comments.

> window function does not support multiple partition columns
> -----------------------------------------------------------
>
>                 Key: CALCITE-1540
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1540
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.10.0
>            Reporter: hongbin ma
>            Assignee: Julian Hyde
>             Fix For: 1.11.0
>
>         Attachments: 
> 0001-CALCITE-1540-window-function-does-not-support-multip.patch
>
>
> When I add multiple partition columns to a window function:
> {code:xml}
>   @Test public void testSelect() throws SQLException {
>     checkSql("model", "select NAME,DEPTNO,count(*) over (partition by 
> NAME,DEPTNO) from EMPS");
>   }
> {code}
> Following exception is thrown:
> java.sql.SQLException: Error while executing SQL "select NAME,DEPTNO,count(*) 
> over (partition by NAME,DEPTNO) from EMPS": Error while compiling generated 
> Java code:
> However the document from calcite.apache.org/docs/reference.html states 
> multiple partition columns should be allowed:
> {code}
> windowSpec:
>       [ windowName ]
>       '('
>       [ ORDER BY orderItem [, orderItem ]* ]
>       [ PARTITION BY expression [, expression ]* ]
>       [
>           RANGE numericOrIntervalExpression { PRECEDING | FOLLOWING }
>       |   ROWS numericExpression { PRECEDING | FOLLOWING }
>       ]
>       ')'
> {code}
> After searching it seems no one is reporting the same issue. I'm opening this 
> JIAR as a placeholder, will try to fix this issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to