[ 
https://issues.apache.org/jira/browse/CALCITE-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongbin ma updated CALCITE-1540:
--------------------------------
    Attachment: 
0001-CALCITE-1540-window-function-does-not-support-multip-2.patch

Refine the patch to make checkstyle happy. 

I was looking for some code fomatter for Calcite but I didn't find any 
(https://mail-archives.apache.org/mod_mbox/calcite-dev/201510.mbox/%3CCAKa9qD=tycnpddqocfzfxq-4wfv7nkatihfhmumkeztiumj...@mail.gmail.com%3E).
 I also tried google java code formatter, which will bring massive blank 
character changes to existing calcite code. 

I find it hard make calcite's checkstyle happy without a standard code 
formatter, especially when my intellij is configured with code formatter from 
other projects. Any suggestions?

> Support multiple columns in PARTITION BY clause of window function
> ------------------------------------------------------------------
>
>                 Key: CALCITE-1540
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1540
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.10.0
>            Reporter: hongbin ma
>            Assignee: hongbin ma
>             Fix For: 1.11.0
>
>         Attachments: 
> 0001-CALCITE-1540-window-function-does-not-support-multip-2.patch, 
> 0001-CALCITE-1540-window-function-does-not-support-multip.patch
>
>
> When I add multiple partition columns to a window function:
> {code:xml}
>   @Test public void testSelect() throws SQLException {
>     checkSql("model", "select NAME,DEPTNO,count(*) over (partition by 
> NAME,DEPTNO) from EMPS");
>   }
> {code}
> Following exception is thrown:
> {noformat}
> java.sql.SQLException: Error while executing SQL "select NAME,DEPTNO,count(*) 
> over (partition by NAME,DEPTNO) from EMPS": Error while compiling generated 
> Java code:
> {noformat}
> However the document from calcite.apache.org/docs/reference.html states 
> multiple partition columns should be allowed:
> {code}
> windowSpec:
>       [ windowName ]
>       '('
>       [ ORDER BY orderItem [, orderItem ]* ]
>       [ PARTITION BY expression [, expression ]* ]
>       [
>           RANGE numericOrIntervalExpression { PRECEDING | FOLLOWING }
>       |   ROWS numericExpression { PRECEDING | FOLLOWING }
>       ]
>       ')'
> {code}
> After searching it seems no one is reporting the same issue. I'm opening this 
> JIAR as a placeholder, will try to fix this issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to