[
https://issues.apache.org/jira/browse/CALCITE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785642#comment-15785642
]
Jess Balint commented on CALCITE-1551:
--------------------------------------
bq. Pig requires that the name of the aggregate is retained. Can you revert the
change you made to PigletTest and make sure it passes.
Not 100% clear on what the alias is doing here, but the reverted test is
passing.
bq. Is there a really good reason why DEPTNO0 became DEPTNO9 in
RelOptRulesTest.xml? We'd like derived field names to be stable, otherwise this
change will break downstream projects.
It was slightly less code to do it this way. I've changed it to name the
duplicate fields the same way as was done before. One small caveat is that
{{RelOptRulesTest.testReduceCasts()}} and
{{StreamTest.testStreamToRelationJoin()}} require minor renamings but are
_more_ consistent now.
bq. It doesn't look as if the set of strings is immutable.
Fixed.
bq. The standard formatting (e.g. for multi-line strings and chained method
calls) is not to align, but indent 4. I am happy to fix these before I commit.
Do you do it in your IDE? If it's not much work for you, that would be great.
Otherwise, I can do it. Do the checkstyle rules need to be amended?
> RelBuilder's project() doesn't preserve alias
> ---------------------------------------------
>
> Key: CALCITE-1551
> URL: https://issues.apache.org/jira/browse/CALCITE-1551
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Jess Balint
> Assignee: Julian Hyde
> Priority: Minor
>
> The alias should be preserved by the project node, e.g.
> {code:java}
> .scan("EMP")
> .as("EMP_alias")
> .project(...) // resets alias to null
> .project(builder.field("EMP_alias", "DEPTNO")) // fails that no such alias
> exists
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
