[ 
https://issues.apache.org/jira/browse/CALCITE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878939#comment-15878939
 ] 

Julian Hyde commented on CALCITE-1653:
--------------------------------------

The change looks basically good. Can you please make the executor mandatory? 
(The method overload without the executor would supply the default executor.)

Also can you please rebase onto latest master branch, squash, and remove merge 
commits.

We may have to revisit this (and break things) when we fix CALCITE-1536. There 
might no longer be a link from RelNode to RelOptPlanner; executor could become 
a property of the cluster.

> Allow for custom RelOptPlanner.Executor in RexUtil.simplify
> -----------------------------------------------------------
>
>                 Key: CALCITE-1653
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1653
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Remus Rusanu
>            Assignee: Julian Hyde
>         Attachments: CALCITE-1653.00.patch
>
>
> {{RexUtil.simplify}} (and derivatives) use a default {{EXECUTOR}} for 
> evaluating literals and expression in {{simplifyCast}}. This causes value 
> differences from Hive, triggering issues like CALCITE-1650, CALCITE-1651. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to