[
https://issues.apache.org/jira/browse/CALCITE-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893012#comment-15893012
]
Kevin Risden commented on CALCITE-1668:
---------------------------------------
Ohhh now that you say that. I think I know what I did wrong previously with the
PR. I thought I was falling through (not simplifying) when things didn't
work/match. I need to be more careful about the comparison and check the type
as well as the value before proceeding.
> RexUtil.simplify handle literal comparison simplification
> ---------------------------------------------------------
>
> Key: CALCITE-1668
> URL: https://issues.apache.org/jira/browse/CALCITE-1668
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Kevin Risden
> Assignee: Julian Hyde
> Priority: Minor
>
> From the calcite-dev mailing list:
> Calcite doesn't seem to optimize away the literal comparison literal case
> with RexUtil.simplify. In my understanding any literal comparison literal
> results in a simple TRUE/FALSE result.
> I'm not sure this is valid in the general case, but I put together a simple
> example of doing this on the RexUtil simplifyCall.
> https://github.com/apache/calcite/pull/376
> Reference:
> http://mail-archives.apache.org/mod_mbox/calcite-dev/201702.mbox/%3CCAJU9nmidm%3DiXNG46YhSthXaBG0CGfmtPraxU9MxEOxnCTTLa_A%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
