[
https://issues.apache.org/jira/browse/CALCITE-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894199#comment-15894199
]
Jesus Camacho Rodriguez edited comment on CALCITE-1661 at 3/3/17 11:57 AM:
---------------------------------------------------------------------------
Fixed up in http://git-wip-us.apache.org/repos/asf/calcite/commit/952214a .
Checked that all unit tests and Druid tests pass, except
_DruidAdapterIT.testFilterTimestamp_.
was (Author: jcamachorodriguez):
Fixed up in http://git-wip-us.apache.org/repos/asf/calcite/commit/3923ca3 .
Checked that all unit tests and Druid tests pass, except
_DruidAdapterIT.testFilterTimestamp_.
> Support aggregation functions on DECIMAL in DruidAdapter
> --------------------------------------------------------
>
> Key: CALCITE-1661
> URL: https://issues.apache.org/jira/browse/CALCITE-1661
> Project: Calcite
> Issue Type: Bug
> Components: druid
> Affects Versions: 1.12.0
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Fix For: 1.12.0
>
>
> Currently, whether to use fractional or integer aggregations is based on
> following code (L699 in DruidQuery.java).
> {code}
> final boolean b = aggCall.getType().getSqlTypeName() == SqlTypeName.DOUBLE;
> {code}
> Since Hive might use other fractional types for the aggregation, we might end
> up using the wrong type of aggregation in Druid. We could extend the check as
> follows:
> {code}
> final boolean b =
> SqlTypeName.FRACTIONAL_TYPES.contains(aggCall.getType().getSqlTypeName());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
