[
https://issues.apache.org/jira/browse/CALCITE-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902305#comment-15902305
]
Julian Hyde commented on CALCITE-1666:
--------------------------------------
One more thing: You added quite a few imports of the rex package into
SqlValidatorImpl. The validator is not supposed to depend on rex, because
validation happens "before" expressions are converted to RexNode. Now, I
understand that in this case the table is using RexNode to express its
constraints. But still, can you think of a way to refactor this so that the
RexNode dependencies don't creep into the validator? For instance, could those
methods go into ModifiableViewTable? (But if so, we don't want
ModifiableViewTable to depend on SqlValidator.)
I'm going to commit your change but I'd like you to refactor the code later to
get the dependencies right.
> Support for modifiable views with extended columns
> --------------------------------------------------
>
> Key: CALCITE-1666
> URL: https://issues.apache.org/jira/browse/CALCITE-1666
> Project: Calcite
> Issue Type: Improvement
> Affects Versions: 1.11.0
> Reporter: Kevin Liew
> Assignee: Julian Hyde
> Labels: validator, view
> Fix For: 1.12.0
>
>
> The changes for this PR is to:
> - propagate extended columns (already parsed into namespaces in the
> validator) through to the planner
> - validate {{INSERT}} and {{UPDATE}} operations against the constraints of
> the modifiable view
> [~maryannxue], [~rajeshbabu], [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
