[
https://issues.apache.org/jira/browse/CALCITE-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905891#comment-15905891
]
Kevin Liew edited comment on CALCITE-1666 at 3/11/17 12:12 AM:
---------------------------------------------------------------
Thanks for the feedback [~julianhyde]. The readability has improved
substantially.
The PR is ready for review again.
For the future revision to insulate {{SqlValidatorImpl}} from {{Rex~}}
dependencies, I'd like to make {{SqlValidatorImpl.newValidationError}} a static
method in {{SqlValidator}} so that it can be called from
{{ModifiableViewTable}}. Does that sound like a good approach? Should I create
a JIRA for the {{newValidationError}} changes?
I will add DDL support for {{CREATE VIEW}} to the extension parser at a later
date. Is that okay?
was (Author: kliew):
Thanks for the feedback [~julianhyde]. The readability has improved
substantially.
The PR is ready for review again.
For the future revision to insulate {{SqlValidatorImpl}} from {{Rex~}}
dependencies, I'd like to make {{SqlValidatorImpl.newValidationError}} a static
method in {{SqlValidator}} so that it can be called from
{{ModifiableViewTable}}. Does that sound like a good approach? Should I create
a JIRA for the {{newValidationError}} changes?
> Support for modifiable views with extended columns
> --------------------------------------------------
>
> Key: CALCITE-1666
> URL: https://issues.apache.org/jira/browse/CALCITE-1666
> Project: Calcite
> Issue Type: Improvement
> Affects Versions: 1.11.0
> Reporter: Kevin Liew
> Assignee: Julian Hyde
> Labels: validator, view
> Fix For: 1.12.0
>
>
> The changes for this PR is to:
> - propagate extended columns (already parsed into namespaces in the
> validator) through to the planner
> - validate {{INSERT}} and {{UPDATE}} operations against the constraints of
> the modifiable view
> [~maryannxue], [~rajeshbabu], [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
