[ 
https://issues.apache.org/jira/browse/CALCITE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944818#comment-15944818
 ] 

Jesus Camacho Rodriguez commented on CALCITE-1707:
--------------------------------------------------

[~bslim], I was reviewing your PR. I run the Druid testsuite and 
_testFilterTimestamp_ is failing.

{code}
Failed tests:
  DruidAdapterIT.testFilterTimestamp:1421
Expected: a string containing "EnumerableInterpreter\n  
BindableAggregate(group=[{}], C=[COUNT()])\n    
BindableFilter(condition=[AND(>=(/INT(Reinterpret($0), 86400000), 1997-01-01), 
<(/INT(Reinterpret($0), 86400000), 1998-01-01), OR(AND(>=(/INT(Reinterpret($0), 
86400000), 1997-04-01), <(/INT(Reinterpret($0), 86400000), 1997-05-01)), 
AND(>=(/INT(Reinterpret($0), 86400000), 1997-06-01), <(/INT(Reinterpret($0), 
86400000), 1997-07-01))))])\n      DruidQuery(table=[[foodmart, foodmart]], 
intervals=[[1900-01-09T00:00:00.000/2992-01-10T00:00:00.000]], projects=[[$0]])"
     but: was "PLAN=EnumerableInterpreter
  DruidQuery(table=[[foodmart, foodmart]], intervals=[[]], 
filter=[=(EXTRACT_DATE(FLAG(YEAR), /INT(Reinterpret($0), 86400000)), 1997)], 
groups=[{}], aggs=[[COUNT()]])
{code}
Change in the plan is incorrect. Observe that _intervals_ is empty and filter 
condition does not contain all the information it should (it only contains the 
filter by year).

I added an additional test without _extract year_ in the Filter condition and 
the result is similar: intervals get lost.

We need to take a look at those errors before we can push this fix.

> Push Extract on Year/Month/Day to druid
> ---------------------------------------
>
>                 Key: CALCITE-1707
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1707
>             Project: Calcite
>          Issue Type: Bug
>          Components: druid
>    Affects Versions: 1.12.0
>            Reporter: slim bouguerra
>            Assignee: Jesus Camacho Rodriguez
>
> This will enable pushing down of time extraction to druid.
> Only day/month/year is supported.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to