[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959890#comment-15959890
 ] 

Jinfeng Ni commented on CALCITE-1742:
-------------------------------------

>From the code,  {{schema.addTable}} is only called when the located TableEntry 
>was not successfully unwrapped into a {{PreparingTable}} instance. If that 
>happens,  it will replace the old one with a new properly created TableEntry 
>in schema.  Seems such addTable call has nothing to do with cache?

1. 
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalciteCatalogReader.java#L148-L149
 

> Avoid caching sub-objects from CalciteSchema if caching is not enabled
> ----------------------------------------------------------------------
>
>                 Key: CALCITE-1742
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1742
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.12.0
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>
> We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
> {{SimpleCalciteSchema}}. There is still caching in the parent class 
> {{CalciteSchema}}, though, that causes objects to be cached even if caching 
> is not enabled (as in {{SimpleCalciteSchema}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to