[
https://issues.apache.org/jira/browse/CALCITE-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983177#comment-15983177
]
ASF GitHub Bot commented on CALCITE-1752:
-----------------------------------------
GitHub user joshelser opened a pull request:
https://github.com/apache/calcite-avatica/pull/7
[CALCITE-1752] Use URLDecoder instead of manually replacing %20
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshelser/calcite-avatica 1752-urldecoder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit b337bb9f7981fa47f42c5db0e937c567dd4b0527
Author: Josh Elser <[email protected]>
Date: 2017-04-25T16:24:57Z
[CALCITE-1752] Use URLDecoder instead of manually replacing %20
----
> Use URLDecoder#decode to handle URLs acquired from getResource(..) calls in
> test cases
> --------------------------------------------------------------------------------------
>
> Key: CALCITE-1752
> URL: https://issues.apache.org/jira/browse/CALCITE-1752
> Project: Calcite
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Fix For: avatica-1.10.0, 1.13.0
>
>
> From
> https://github.com/apache/calcite/commit/6543c0fd8b63efb00d035790209f8546668d7aa5#commitcomment-21723380:
> [~michaelmior] suggested that it would be better to replace my
> {{String.replace("%20", " ")}} with {{java.net.URLDecoder.decode}} instead. I
> am apt to agree with him :)
> Maybe we can pull this into a utility instead of littering it around test
> cases in avatica and calcite.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
