[ 
https://issues.apache.org/jira/browse/CALCITE-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde resolved CALCITE-1761.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.13.0

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/a11d1405.

Thanks for the test case, [~wheat9]!

> TUMBLE/HOP/SESSION_START/END do not resolve time field correctly
> ----------------------------------------------------------------
>
>                 Key: CALCITE-1761
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1761
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.12.0
>            Reporter: Timo Walther
>            Assignee: Julian Hyde
>             Fix For: 1.13.0
>
>
> It seems there is a bug in the resolution logic of SqlToRelConverter.
> The problem is as follows:
> Input: {{MyTable(INTEGER a, VARCHAR b, BIGINT c, TIMESTAMP proctime, 
> TIMESTAMP rowtime)}}
> SQL: {{SELECT COUNT(*), TUMBLE_START(rowtime, INTERVAL '15' MINUTE), 
> TUMBLE_END(rowtime, INTERVAL '15' MINUTE) FROM MyTable GROUP BY 
> TUMBLE(rowtime, INTERVAL '15' MINUTE)}}
> Exception:
> {code}
> java.lang.RuntimeException: while converting 
> TUMBLE_START(`MyTable`.`rowtime`, INTERVAL '15' MINUTE)
>     at 
> org.apache.calcite.sql2rel.ReflectiveConvertletTable$2.convertCall(ReflectiveConvertletTable.java:134)
>     at 
> org.apache.calcite.sql2rel.SqlNodeToRexConverterImpl.convertCall(SqlNodeToRexConverterImpl.java:61)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4415)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:3783)
>     at org.apache.calcite.sql.SqlCall.accept(SqlCall.java:137)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:4317)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.createAggImpl(SqlToRelConverter.java:2723)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertAgg(SqlToRelConverter.java:2541)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:654)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:616)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:2951)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:552)
>     .....
> Caused by: java.lang.reflect.InvocationTargetException
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.apache.calcite.sql2rel.ReflectiveConvertletTable$2.convertCall(ReflectiveConvertletTable.java:131)
>     ... 42 more
> Caused by: java.lang.AssertionError
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.getRootField(SqlToRelConverter.java:4132)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.adjustInputRef(SqlToRelConverter.java:3446)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertIdentifier(SqlToRelConverter.java:3421)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter.access$1800(SqlToRelConverter.java:207)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4424)
>     at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java
> {code}
> Additionally, tests were added to
> SqlToRelConverterTest.xml but not to SqlToRelConverterTest.java. We've
> been running without tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to