[ 
https://issues.apache.org/jira/browse/CALCITE-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001636#comment-16001636
 ] 

slim bouguerra commented on CALCITE-1777:
-----------------------------------------

I think what i proposed is just in calcite and i think it joins what your are 
describing above, when i said generate the Json Filter and push only if the 
filter json  is a valid Druid filter means use the code generating the json 
string to examine the rel nodes, like that if we get a null string we know we 
can not push the filter.
are we in the same page ? 

> Druid adapter: "WHERE FALSE" causes AssertionError
> --------------------------------------------------
>
>                 Key: CALCITE-1777
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1777
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> Query with "WHERE FALSE" gives AssertionError in Druid adapter.
> Originally logged as part of CALCITE-1775. Test case in {{DruidAdapterIT}}:
> {code}
>   @Test public void testSelectCountFalse() {
>     sql("select count(*) as c from \"foodmart\" where 1 < 0")
>         .returnsUnordered("C=0");
>   }
> {code}
> gives
> {noformat}
> java.lang.AssertionError: cannot translate filter: false
>       at 
> org.apache.calcite.adapter.druid.DruidQuery$Translator.translateFilter(DruidQuery.java:1067)
>       at 
> org.apache.calcite.adapter.druid.DruidQuery$Translator.access$000(DruidQuery.java:933)
>       at 
> org.apache.calcite.adapter.druid.DruidQuery.getQuery(DruidQuery.java:497)
>       at 
> org.apache.calcite.adapter.druid.DruidQuery.deriveQuerySpec(DruidQuery.java:470)
>       at 
> org.apache.calcite.adapter.druid.DruidQuery.getQuerySpec(DruidQuery.java:414)
>       at 
> org.apache.calcite.adapter.druid.DruidQuery.deriveRowType(DruidQuery.java:308)
>       at 
> org.apache.calcite.rel.AbstractRelNode.getRowType(AbstractRelNode.java:224)
>       at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:857)
>       at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:883)
>       at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:1769)
>       at 
> org.apache.calcite.plan.volcano.VolcanoRuleCall.transformTo(VolcanoRuleCall.java:135)
>       at 
> org.apache.calcite.plan.RelOptRuleCall.transformTo(RelOptRuleCall.java:225)
>       at 
> org.apache.calcite.adapter.druid.DruidRules$DruidFilterRule.onMatch(DruidRules.java:228)
>       at 
> org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:211)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to