[
https://issues.apache.org/jira/browse/CALCITE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006091#comment-16006091
]
sunjincheng edited comment on CALCITE-1780 at 5/11/17 8:36 AM:
---------------------------------------------------------------
Hi [~julianhyde], I have opened the PR.
https://github.com/apache/calcite/pull/446
was (Author: sunjincheng121):
Hi [~djulian], I have opened the PR. https://github.com/apache/calcite/pull/446
> Add `required Order` and `requiresOver` parameters to the constructor of
> `SqlUserDefinedAggregate Function`
> -----------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-1780
> URL: https://issues.apache.org/jira/browse/CALCITE-1780
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Currently {{org.apache.calcite.sql.validate.SqlUserDefinedAggFunction}} calls
> the constructor of SqlAggFunction:
> {code}
> Protected SqlAggFunction (
> String name,
> SqlIdentifier sqlIdentifier,
> SqlKind kind,
> SqlReturnTypeInference returnTypeInference,
> SqlOperandTypeInference operandTypeInference,
> SqlOperandTypeChecker operandTypeChecker,
> SqlFunctionCategory funcType,
> Boolean requiresOrder,
> Boolean requiresOver)
> {code}
> The requiresOrder = false, requiresOver = false. as follow:
> {code}
> Public SqlUserDefinedAggFunction (SqlIdentifier opName,
> SqlReturnTypeInference returnTypeInference,
> SqlOperandTypeInference operandTypeInference,
> SqlOperandTypeChecker operandTypeChecker, AggregateFunction function) {
> Super (Util.last (opName.names), opName, SqlKind.OTHER_FUNCTION,
> ReturnTypeInference, operandTypeInference, operandTypeChecker,
> SqlFunctionCategory.USER_DEFINED_FUNCTION, false, false);
> This.function = function;
> }
> {code}
> I want add `required Order` and `requiresOver` parameters to the constructor
> of `SqlUserDefinedAggregate Function`.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
