[
https://issues.apache.org/jira/browse/CALCITE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007474#comment-16007474
]
Julian Hyde commented on CALCITE-1782:
--------------------------------------
I saw your PR https://github.com/apache/calcite/pull/447. Please update the
comments in that file.
> AggregateExpandDistinctAggregatesRule should work on Aggregate instead of
> LogicalAggregate
> ------------------------------------------------------------------------------------------
>
> Key: CALCITE-1782
> URL: https://issues.apache.org/jira/browse/CALCITE-1782
> Project: Calcite
> Issue Type: Bug
> Reporter: Haohui Mai
> Assignee: Haohui Mai
>
> {{AggregateExpandDistinctAggregatesRule}} expects the operator to be a
> subclass of {{LogicalAggregate}}:
> {noformat}
> public AggregateExpandDistinctAggregatesRule(
> Class<? extends LogicalAggregate> clazz,
> RelFactories.JoinFactory joinFactory) {
> this(clazz, false, RelBuilder.proto(Contexts.of(joinFactory)));
> }
> {noformat}
> However, {{LogicalAggregate}} is a final class which cannot be inherited.
> This jira proposes to change the signature from {{LogicalAggregate}} to
> {{Aggregate}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
