[ 
https://issues.apache.org/jira/browse/CALCITE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028280#comment-16028280
 ] 

Julian Hyde edited comment on CALCITE-1584 at 5/30/17 2:01 AM:
---------------------------------------------------------------

[~julianhyde] in [email 
thread|https://lists.apache.org/thread.html/de9b3eb0d9e2b2ef191a2c4a7fe395d2ff5d01131c9f5a500aa8f26a@%3Cdev.calcite.apache.org%3E]
 you have mentioned:
{quote}
ProjectRemoveRule currently takes one argument (the trivial project) but to see 
the real type of that project's input the rule would need to take two arguments.
{quote}

I was going to prepare the fix for this issue but I did not quite get this 
comment. Actually, I was going to modify RexUtil.isIdentity method to take 
three arguments and compare field names as well as field types (as it was 
before Vladimir changes). If I am not correct, could you please explain your 
comment? Thank you in advance!



was (Author: arina):
[~julianhyde] in email thread you have mentioned:
{noformat}
ProjectRemoveRule currently takes one argument (the trivial project) but to see 
the real type of that project's input the rule would need to take two arguments.
{noformat}

I was going to prepare the fix for this issue but I did not quite get this 
comment. Actually, I was going to modify RexUtil.isIdentity method to take 
three arguments and compare field names as well as field types (as it was 
before Vladimir changes). If I am not correct, could you please explain your 
comment? Thank you in advance!


> ProjectRemoveRule loses field names
> -----------------------------------
>
>                 Key: CALCITE-1584
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1584
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Jess Balint
>            Assignee: Julian Hyde
>            Priority: Minor
>
> the rule doesn't properly identify a child {{Project}} node



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to