[
https://issues.apache.org/jira/browse/CALCITE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062411#comment-16062411
]
Julian Hyde commented on CALCITE-1709:
--------------------------------------
Review comments:
* Need spaces after commas in both code and comments
* s/optinal/optional
* Using '.' in field names is a hack; log a JIRA case describing what is broken
by this hack
* I know you added a validator test, but can you also add a parser test. See
SqlParserTest.testTableExtend.
> Support mixing table columns with extended columns in DML
> ---------------------------------------------------------
>
> Key: CALCITE-1709
> URL: https://issues.apache.org/jira/browse/CALCITE-1709
> Project: Calcite
> Issue Type: New Feature
> Affects Versions: 1.11.0
> Reporter: Kevin Liew
> Assignee: Rajeshbabu Chintaguntla
>
> Phoenix allows embedding dynamic column definitions in the {{UPDATE}} target
> column list whereas Calcite requires that extended columns be specified
> separately from the target columns.
> ie.
> Phoenix
> {code:sql}
> UPSERT INTO EventLog
> (eventId, eventTime, eventType, lastGCTime TIME, usedMemory BIGINT, maxMemory
> BIGINT)
> VALUES (1, CURRENT_TIME(), ‘abc’, CURRENT_TIME(), 512, 1024);
> {code}
> Calcite
> {code:sql}
> UPSERT INTO EventLog
> (lastGCTime TIME, usedMemory BIGINT, maxMemory BIGINT)
> (eventId, eventTime, eventType, lastGCTime, usedMemory, maxMemory)
> VALUES (1, CURRENT_TIME(), ‘abc’, CURRENT_TIME(), 512, 1024);
> {code}
> We should have a conformance setting for this feature.
> https://issues.apache.org/jira/browse/PHOENIX-3732?focusedCommentId=15930704&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15930704
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
