[
https://issues.apache.org/jira/browse/CALCITE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077149#comment-16077149
]
Julian Hyde commented on CALCITE-1709:
--------------------------------------
As I said, we need a new JIRA case, and only when we think we've found all the
issues.
Comments:
* In SqlValidatorTest, sql0 should be final.
* Can you move the new relation into MockCatalogReader.init2, and use
withExtendedCatalog2003 just as testInsertSubsetModifiableView does. We're
trying to keep the mock catalog as simple as possible.
* In testCheckingDuplicatesWithCompoundIdentifiers there's no need to catch
AssertionError. And can you add a negative test that is supposed to fail and
throw CalciteContextException.
> Support mixing table columns with extended columns in DML
> ---------------------------------------------------------
>
> Key: CALCITE-1709
> URL: https://issues.apache.org/jira/browse/CALCITE-1709
> Project: Calcite
> Issue Type: New Feature
> Affects Versions: 1.11.0
> Reporter: Kevin Liew
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 1.14.0
>
>
> Phoenix allows embedding dynamic column definitions in the {{UPDATE}} target
> column list whereas Calcite requires that extended columns be specified
> separately from the target columns.
> ie.
> Phoenix
> {code:sql}
> UPSERT INTO EventLog
> (eventId, eventTime, eventType, lastGCTime TIME, usedMemory BIGINT, maxMemory
> BIGINT)
> VALUES (1, CURRENT_TIME(), ‘abc’, CURRENT_TIME(), 512, 1024);
> {code}
> Calcite
> {code:sql}
> UPSERT INTO EventLog
> (lastGCTime TIME, usedMemory BIGINT, maxMemory BIGINT)
> (eventId, eventTime, eventType, lastGCTime, usedMemory, maxMemory)
> VALUES (1, CURRENT_TIME(), ‘abc’, CURRENT_TIME(), 512, 1024);
> {code}
> We should have a conformance setting for this feature.
> https://issues.apache.org/jira/browse/PHOENIX-3732?focusedCommentId=15930704&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15930704
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
