[
https://issues.apache.org/jira/browse/CALCITE-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090441#comment-16090441
]
Julian Hyde commented on CALCITE-1883:
--------------------------------------
The change looks good, and I would like to commit it.
However, you ([~tedxu]) do not seem to be the author of the change, so I'm not
sure I can accept the pull request.
> HepPlanner should force garbage collect whenever a root registered
> ------------------------------------------------------------------
>
> Key: CALCITE-1883
> URL: https://issues.apache.org/jira/browse/CALCITE-1883
> Project: Calcite
> Issue Type: Bug
> Reporter: Ted Xu
> Assignee: Julian Hyde
>
> Currently HepPlanner#collectGarbage() will skip if there is no new transform
> since last GC. If HepPlanner is reused, it is common case that no transform
> is applied after last cheapest plan is built while before next round of
> optimize is kicked off.
> This may break HepPlanner because the garbage is probably not a graph after
> HepPlanner#buildFinalPlan .
> I'll try if I can create a reproduce case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
