[ 
https://issues.apache.org/jira/browse/CALCITE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106543#comment-16106543
 ] 

Chris Baynes commented on CALCITE-1895:
---------------------------------------

I've updated the PR with the {{throws_}} and {{IllegalArgumentException}} as 
you suggested (I never liked the idea of catching the {{AssertionError}} but 
didn't see a more appropriate exception at the time).

As for the test I don't see support for mssql in the calcite-test-dataset, 
though I can run an instance on aws to try that locally. 
If I write that test in {{JdbcAdapterTest}} will it be run against Mssql on 
travis-ci? Is there a config of jdbc dbs that are tested against?

> Substring operator broken for MSSQL
> -----------------------------------
>
>                 Key: CALCITE-1895
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1895
>             Project: Calcite
>          Issue Type: Bug
>          Components: jdbc-adapter
>            Reporter: Chris Baynes
>            Assignee: Julian Hyde
>
> The format mssql uses looks like:
> SUBSTRING(input, start, length)
> but the default is currently to unparse to SUBSTRING(input FROM start FOR 
> length)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to