[ 
https://issues.apache.org/jira/browse/CALCITE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115655#comment-16115655
 ] 

Julian Hyde commented on CALCITE-1849:
--------------------------------------

Wow, sorry I missed this the first time. I reviewed as of 
https://github.com/apache/calcite/pull/477/commits/347963bb5987137bea884c14668cf6aad58d45da.

Looks great, but just one thing: in SqlImplementor.java line 616, what happens 
if rex is not an instance of RexSubQuery? Looks like there will be a 
ClassCastException as it falls through to the next case. Can you test that 
case, and fix the code? Or maybe {{rex instanceof RexSubQuery}} is always true 
in practice.

> SubQuery in not support in reltosql when SqlToRelConverter.Config.expand = 
> false
> --------------------------------------------------------------------------------
>
>                 Key: CALCITE-1849
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1849
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.12.0
>            Reporter: Zhiqiang He
>            Assignee: Zhiqiang He
>
> In SqltoRelConvert, the subquery will be convert into Join clause in default 
> config.
> when SqlToRelConverter.Config.expand = false, subquery will not convert to 
> Join. and reltosqlconvert is not support subquery.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to