[ 
https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990
 ] 

Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:20 AM:
------------------------------------------------------------------

Hey [~julianhyde]

Thanks for the comments. I added the header to wercker.yml, but I am not sure 
how to add the header to README.md and .gitignore. See the following in the 
calcite repo: https://github.com/apache/calcite/blob/master/README and 
https://github.com/apache/calcite/blob/master/.gitignore

Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is 
poised to become the official package manager for Go. This file must be 
committed as it contains the exact commit hashes of the dependencies installed. 
The Gopkg.toml file only contains the constraints, for example, use the minor 
versions of a dependency that is versioned at 1.2.1. Therefore, the lock file 
is required for reproducible builds. It is equivalent to the lock file used by 
NPM 5.

The vendor directory contains dependencies used by the calcite-avatica-go 
library. When running tests, libraries and projects do not run tests in the 
vendor directory. The vendored dependencies should have their own tests and the 
owner of the dependencies should be testing them.

It does not make any sense to build the library. The library should be add into 
a project using dep, which will copy it to the project's vendor directory. On 
compilation, Go will build a single static binary for the project.

I've pushed updated the PR with changes to the readme and a license header to 
wercker.yml.


was (Author: francischuang):
Hey [~julianhyde]

Thanks for the comments. I added the header to wercker.yml, but I am not sure 
how to add the header to README.md and .gitignore. See the following in the 
calcite repo: https://github.com/apache/calcite/blob/master/README and 
https://github.com/apache/calcite/blob/master/.gitignore

Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is 
poised to become the official package manager for Go. This file must be 
committed as it contains the exact commit hashes of the dependencies installed. 
The Gopkg.toml file only contains the constraints, for example, use the minor 
versions of a dependency that is versioned at 1.2.1. Therefore, the lock file 
is required for reproducible builds. It is equivalent to the lock file used by 
NPM 5.

The vendor directory contains dependencies used by the calcite-avatica-go 
library. When running tests, libraries and projects to not run tests in the 
vendor directory. The vendored dependencies should have their own tests and the 
owner of the dependencies should be testing them.

It does not make any sense to build the library. The library should be add into 
a project using dep, which will copy it to the project's vendor directory. On 
compilation, Go will build a single static binary for the project.

I've pushed updated the PR with changes to the readme and a license header to 
wercker.yml.

> Avatica client written in Golang
> --------------------------------
>
>                 Key: CALCITE-1240
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1240
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> Add a client for Avatica written in the Go language (aka "Golang").
> There is one at https://github.com/Boostport/avatica and the author has 
> offered to contribute it.
> The driver is currently somewhat specialized for Phoenix but our goal should 
> be to allow it to work against any Avatica provider (without diminishing its 
> value to Phoenix users).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to