[ 
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123502#comment-16123502
 ] 

Julian Hyde commented on CALCITE-1911:
--------------------------------------

You've addressed almost everything. I was pleased to see negative tests for 
ORDER BY.

Can you make the unit tests for intervals much smaller? The only difference 
between testMatchRecognizeWithin6 and testMatchRecognizeWithin7 is the kind of 
interval. That's the purpose of those tests, after all. You know that, I know 
that, but whoever maintains this code in the future won't be able to see the 
wood for the trees. Don't write a 50 line test when a 1 line test will do. As I 
said earlier, you can test using a 1-line VALUES statement.

> Support WITHIN clause in MATCH_RECOGNIZE
> ----------------------------------------
>
>                 Key: CALCITE-1911
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1911
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Dian Fu
>            Assignee: Julian Hyde
>              Labels: match
>
> Window is an important feature for pattern detection, it defines the time 
> duration for the events to match a pattern. Here is an example from 
> [doc|https://docs.oracle.com/middleware/1213/eventprocessing/cql-reference/GUID-34D4968E-C55A-4BC7-B1CE-C84B202217BD.htm#CQLLR2119]:
> {code}
> SELECT T.Ac2, T.Bc2, T.Cc2 
>     FROM S
>     MATCH_RECOGNIZE(
>         MEASURES A.c2 as Ac2, B.c2 as Bc2, C.c2 as Cc2
>         PATTERN (A (B+ | C)) within 3000 milliseconds 
>         DEFINE 
>             A as A.c1=10 or A.c1=25, 
>             B as B.c1=20 or B.c1=15 or B.c1=25, 
>             C as C.c1=15
>     ) as T
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to