[
https://issues.apache.org/jira/browse/CALCITE-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125192#comment-16125192
]
Francis Chuang commented on CALCITE-1938:
-----------------------------------------
{quote}
Couldn't something be done to figure out the flavor of database and what it
supports? I think we have driver information already sent back from the server.
Maybe it's as simple as returning that back? Syntax shouldn't matter for the
driver itself, just the sql provided, no?
{quote}
>From the RpcMetadata message, I only see that the server_address is returned.
>However, I don't think this is a blocker, because if we have a test matrix
>like in travis-ci, we can execute both the Phoenix and HSQLdb tests separately
>by switching against a environment variable.
The driver does not care about the syntax itself, however in the tests, we
execute statements against Phoenix using `UPSERT ...`. Since HSQLdb uses
insert/update, we would need to rewrite the SQL statements in the appropriate
syntax. There is also a test that inserts into a table using all the various
Phoenix data types and selects them to see that the data is being saved and
read correctly, and we'd need a seperate one for HSQLdb.
These are not insurmountable challenges. Since all the integration tests are in
driver_test.go, we could turn that into driver_phoenix_test.go and
driver_hsqldb_test.go and have the different flavors run depending on what the
environment variable AVATICA_FLAVOR is set to.
{quote}
Anyways, I don't think it's a good use of our time to try to deploy a full
hbase installation on the ASF infra. It tends to be over-taxed already – a
minimal testing environment is the best plan of action.
{quote}
I agree that it's not productive to set up an HBase install, but if we are
using jenkins, is it possible to use a docker image as a service? If so, my
hbase-phoenix-all-in-one image spins up a container that has hbase-standalone,
phoenix, pqs and tephra enabled. This should require about the same effort as
testing against the avatica-hsqldb image.
> First Apache release for Avatica Go
> -----------------------------------
>
> Key: CALCITE-1938
> URL: https://issues.apache.org/jira/browse/CALCITE-1938
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
> Reporter: Julian Hyde
> Assignee: Francis Chuang
>
> Make a release for Avatica Go.
> Release number is TBD.
> This will be the first Apache release for Avacica Go, so expect more
> diligence / issues than usual.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
