[
https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144583#comment-16144583
]
Julian Hyde commented on CALCITE-1943:
--------------------------------------
Looks good. I will commit when tests pass. I changed NavigationReplacer.visit
to call super.visit; it's simpler than what you had.
On reflection, your approach of modifying the SqlNode tree is an anti-pattern.
Ask anyone who has tried to optimize queries by changing the AST. It quickly
becomes a mess. The next time you need something like NavigationReplacer, it
should operate on RexNode rather than SqlNode.
> Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl
> ----------------------------------------------------------------------
>
> Key: CALCITE-1943
> URL: https://issues.apache.org/jira/browse/CALCITE-1943
> Project: Calcite
> Issue Type: Bug
> Reporter: Dian Fu
> Assignee: Julian Hyde
>
> {{NavigationExpander}} and {{NavigationReplacer}} was deleted as a fix of
> issue CALCITE-1871. Just create this ticket to track whether we should add
> them back.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
