[
https://issues.apache.org/jira/browse/CALCITE-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153125#comment-16153125
]
Julian Hyde commented on CALCITE-1947:
--------------------------------------
+1 when you've made the (mainly cosmetic) fixes below.
I was a bit confused until I realized that the TimestampWithTimeZone and
TimeWithTimeZone classes are basically just for future use.
The SQL type is "TIMESTAMP WITH LOCAL TIME ZONE" not "TIMESTAMP WITH LOCAL
TIMEZONE". Can you rename SqlTypeName.TIMESTAMP_WITH_LOCAL_TIMEZONE
accordingly. Similarly TIME WITH LOCAL TIME ZONE. Also search for "timezone"
in comments, and change BuiltInMethod constants that contain "TIMEZONE".
In Schemas.java you changed TIME_ZONE and CURRENT_TIMESTAMP to hard-coded
constants. A mistake, I think.
Can you add entries to the table in reference.md.
> Add time/timestamp with local time zone types to optimizer
> ----------------------------------------------------------
>
> Key: CALCITE-1947
> URL: https://issues.apache.org/jira/browse/CALCITE-1947
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Fix For: 1.14.0
>
>
> Implementation would be similar to PostgreSQL (the {{time/timestamp with
> timezone}} types do not store the timezone) and conversion from/to
> timezone-less types follows similar semantics.
> https://www.postgresql.org/docs/9.6/static/functions-datetime.html
> This would also allow us to integrate easily with Hive and Druid, which
> follow similar storage models/semantics for timestamp with timezone.
> Follow-up work will be needed to introduce these new types in Avatica and
> extend Calcite SQL parser.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
