[
https://issues.apache.org/jira/browse/CALCITE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183074#comment-16183074
]
Julian Hyde edited comment on CALCITE-1988 at 9/27/17 6:46 PM:
---------------------------------------------------------------
The issues are described in [a
patch|https://github.com/julianhyde/calcite/commit/603e6bde4bcca9fdc6233d1bd762040e891cb1af]
that I plan to push to master right after 1.14:
* Fix error that SqlNode.clone does not call super.clone; deprecate
it, and add SqlNode.clone(SqlNode)
* Fix error that NlsString.clone does not call super.clone
* Make AggregateNode.AccumulatorList static, because non-static inner
classes must not implement Serializable
* Change XmlOutput.content to not use LineNumberReader.readLine, which
is susceptible to a DoS attack
I agree that a review of Coverity output would be good. It's out of scope of
this bug, though.
was (Author: julianhyde):
The issues are described in [a
patch|https://github.com/julianhyde/calcite/commit/603e6bde4bcca9fdc6233d1bd762040e891cb1af]
that I push to master right after 1.14:
* Fix error that SqlNode.clone does not call super.clone; deprecate
it, and add SqlNode.clone(SqlNode)
* Fix error that NlsString.clone does not call super.clone
* Make AggregateNode.AccumulatorList static, because non-static inner
classes must not implement Serializable
* Change XmlOutput.content to not use LineNumberReader.readLine, which
is susceptible to a DoS attack
I agree that a review of Coverity output would be good. It's out of scope of
this bug, though.
> Various code quality issues
> ---------------------------
>
> Key: CALCITE-1988
> URL: https://issues.apache.org/jira/browse/CALCITE-1988
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
