[ 
https://issues.apache.org/jira/browse/CALCITE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216306#comment-16216306
 ] 

Julian Hyde commented on CALCITE-1867:
--------------------------------------

As a new API, there really ought to be tests (using a mock implementation of 
SqlGroupWindowFunction) to make sure that the interface encapsulates 
everything. Otherwise we both know that this feature will be extremely brittle. 
If we don't add those tests, we should tag this {{@Experimental}}.



> Allow creating additional SqlGroupFunctions
> -------------------------------------------
>
>                 Key: CALCITE-1867
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1867
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Timo Walther
>            Assignee: Julian Hyde
>
> In Flink we want to create additional group auxiliary functions (such as 
> {{TUMBLE_ROWTIME(), TUMBLE_PROCTIME()}}). 
> Unfortunately, {{SqlGroupFunction}} and its methods are package-private which 
> prevents us from adding custom functions. Also {{AuxiliaryConverter}} limits 
> because it is statically defined and not pluggable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to