[ 
https://issues.apache.org/jira/browse/CALCITE-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236272#comment-16236272
 ] 

Michael Mior commented on CALCITE-2031:
---------------------------------------

I implemented {{ST_X}} and {{ST_Y}} in 
[17cd76af7|https://github.com/apache/calcite/commit/17cd76af79920524e7da12a08acee3b52f0055a8].
 As far as getting examples from H2GIS, if copy-paste is not permissible, then 
what is? Also, looking at the examples it seems like {{ST_Z}} (and also my 
implementations of {{ST_X}} and {{ST_Y}}) do not cover all the cases they 
should. They currently only work for points when the examples show them working 
for many other types.

> Implement more OpenGIS functions
> --------------------------------
>
>                 Key: CALCITE-2031
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2031
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> The initial set of OpenGIS functions were implemented in CALCITE-1968 but 
> there are quite a few more to implement.
> Each function can be implemented separately, and with very little effort: you 
> typically need to find the commented function in in 
> {{[spatial.iq|https://github.com/apache/calcite/blob/master/core/src/test/resources/sql/spatial.iq]}}
>  (it will be followed by the comment {{# Not implemented}}), add one or two 
> queries as test case, add a method to {{GeoFunctions.java}}, iterate until 
> the test cases work, then add a row to one of the tables in {{reference.md}} 
> to document that the function is now implemented.
> I suggest that each pull request implements a few related functions. A good 
> place to start would be {{ST_X(geom)}}; {{ST_Z(geom)}} is very similar and is 
> already implemented.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to