[
https://issues.apache.org/jira/browse/CALCITE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244315#comment-16244315
]
Julian Hyde commented on CALCITE-2041:
--------------------------------------
[~bslim], Your communication style is difficult. What does it mean when you
post a link to a PR, with no other text, as a comment to a JIRA case? (You did
this in this case, CALCITE-2041, and also in CALCITE-2019.) Most people would
assume this means that the PR is ready to review and commit.
You seem to think this is personal. It is not. But I sure do get pissed off
when people waste my time, as you did, by posting incomplete PRs without any
indication that they were incomplete. I would have been a lot less pissed off
if, after the checkstyle issue in CALCITE-2019, you had simply said "Sorry,
I'll fix it."
And now you are accusing me of making personal attacks. What you think that is
going to do for our working relationship?
> Adding the ability to turn off nullability matching for ReduceExpressionsRule
> -----------------------------------------------------------------------------
>
> Key: CALCITE-2041
> URL: https://issues.apache.org/jira/browse/CALCITE-2041
> Project: Calcite
> Issue Type: Bug
> Reporter: slim bouguerra
> Assignee: Julian Hyde
>
> In some cases, the user needs to select whether or not to add casts that
> match nullability.
> One of the motivations behind this is to avoid unnecessary casts like the
> following example.
> original filter
> {code}
> OR(AND(>=($0, CAST(_UTF-16LE'2010-01-01 00:00:00
> UTC'):TIMESTAMP_WITH_LOCAL_TIME_ZONE(15)), <=($0, CAST(_UTF-16LE'2012-03-01
> 00:00:00 UTC'):TIMESTAMP_WITH_LOCAL_TIME_ZONE(15))))
> {code}
> the optimized expression with matching nullability
> {code}
> OR(AND(CAST(>=($0, 2010-01-01 00:00:00)):BOOLEAN, CAST(<=($0, 2012-03-01
> 00:00:00)):BOOLEAN))
> {code}
> As you can see this extra cast gets into the way of following plan
> optimization steps.
> The desired expression can be obtained by turning off the nullability
> matching.
> {code}
> OR(AND(>=($0, 2010-01-01 00:00:00), <=($0, 2012-03-01 00:00:00)))
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
