[
https://issues.apache.org/jira/browse/CALCITE-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244819#comment-16244819
]
Julian Hyde commented on CALCITE-2043:
--------------------------------------
Reviewing
https://github.com/apache/calcite/pull/564/commits/11dd804f982394590a5537e55f6bfce96ac9af7d.
It looks good - nice work! A couple of minor things:
* Where you've added a new constructor, and the old one is public (e.g.
AggregateRemoveRule), can you please mark the one one deprecated, "@Deprecated
// to be removed before 2.0". We want to keep our API as small as possible. Run
"mvn verify" before check-in to make sure that we don't call deprecated methods.
* When method parameters go onto the next line, our coding style is to indent
them 4 spaces, not line them up with the '(' as you have done in some places.
* If a constructor is now public, make sure it has javadoc.
> Use custom RelBuilder implementation in some rules
> --------------------------------------------------
>
> Key: CALCITE-2043
> URL: https://issues.apache.org/jira/browse/CALCITE-2043
> Project: Calcite
> Issue Type: Bug
> Reporter: Volodymyr Vysotskyi
> Assignee: Julian Hyde
>
> Some rules do not have constructors with RelBuilderFactory.
> List of such rules that are used in Drill:
> * AggregateRemoveRule
> * ProjectRemoveRule
> * SortRemoveRule
> * ProjectWindowTransposeRule
> * ExpandConversionRule
> * ConverterRule
> * JoinToMultiJoinRule
> * ProjectToWindowRule
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
