[ 
https://issues.apache.org/jira/browse/CALCITE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295759#comment-16295759
 ] 

Piotr Bojko commented on CALCITE-2093:
--------------------------------------

When locale specific cases should be avoided then the whole OsAdapterTest is 
not on track with such thinking. BSD machines, Solaris etc - they are all not 
taken into consideration in this test, not sure that whole linux family could 
pass through the mentioned test.

 I agree with isolation in tests from locale and testing strictly the Calcite 
itself, not the environment , but to meet this requirement OsAdapterTest should 
rather mock environment, not use it as a source of data.  OsAdapterTest is not 
a clear test - it rather shows some possibilities in using Calcite. 

Maybe the best way is to remove the field from the whole tests? "Possibilities" 
would be clearly still presented and chance for another locales problem 
lowered. 
 

> OsAdapterTest in Calcite Plus does not respect locale
> -----------------------------------------------------
>
>                 Key: CALCITE-2093
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2093
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.16.0
>            Reporter: Piotr Bojko
>            Assignee: Piotr Bojko
>            Priority: Minor
>
> On Linux when PL locales are applied FileTableFunction java uses Float.parse 
> which does not consider os locales but rather uses dot for float numbers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to