[ 
https://issues.apache.org/jira/browse/CALCITE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299355#comment-16299355
 ] 

Julian Hyde commented on CALCITE-2092:
--------------------------------------

[~vvysotskyi], Thanks for the PR. I reworked it a bit, because rather than 
adding a constructor parameter to SqlToRelConverter, it's lower impact to add a 
RelBuilderFactory to SqlToRelConverter.Config. Please take a look at 
https://github.com/julianhyde/calcite/commit/9c6dc773e31a8b555350a75a6e9d9199b8244219
 and if you +1 and my tests pass I'll commit.

> Allow passing custom RelBuilder into SqlToRelConverter
> ------------------------------------------------------
>
>                 Key: CALCITE-2092
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2092
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Julian Hyde
>
> Currently, {{SqlToRelConverter}} uses {{RelBuilder}} which was created in 
> such a way:
> {code:java}
> RelFactories.LOGICAL_BUILDER.create(cluster, null)
> {code}
> So it is not possible to use custom {{RelBuilder}} in this class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to