[ 
https://issues.apache.org/jira/browse/CALCITE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322839#comment-16322839
 ] 

Julian Hyde commented on CALCITE-2090:
--------------------------------------

It's fine that these are all in the same PR. They're all related, and you have 
made tests for everything (thank you!), so a single PR is easier to review.

I've reviewed, and it all looks good. Did you consider including CEIL as well, 
since it is the dual of FLOOR?

> Extend Druid Range Rules to extract interval from Floor
> -------------------------------------------------------
>
>                 Key: CALCITE-2090
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2090
>             Project: Calcite
>          Issue Type: Improvement
>          Components: druid
>            Reporter: Nishant Bangarwa
>            Assignee: Nishant Bangarwa
>
> DruidRangeRules currently only extracts intervals from EXTRACT function. 
> This task is to enhance Druid Range Rules to also support Floor functions. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to