[
https://issues.apache.org/jira/browse/CALCITE-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331942#comment-16331942
]
Julian Hyde commented on CALCITE-2144:
--------------------------------------
if you make this change, how big is the impact? E.g. how many tests does it
break?
I think that most of the time, the operator name is a sensible alias,
especially if the operator is function. Even operator names that are symbols
should be OK as field names, provided that they're quoted. But I have no
objection to replacing "*" with "MULTIPLY", etc.
> PushProjector - it name the field using the name of the operators
> ------------------------------------------------------------------
>
> Key: CALCITE-2144
> URL: https://issues.apache.org/jira/browse/CALCITE-2144
> Project: Calcite
> Issue Type: Improvement
> Affects Versions: 1.15.0
> Environment:
> {code:java}
> // code placeholder
> {code}
>
> //PushProjector.java (line 505)
>
> for (RexNode projExpr : preserveExprs) {
> .........
> newProjects.add(
> Pair.of(newExpr,
> ((RexCall) projExpr).getOperator().getName()));
> }
> return (Project) RelOptUtil.createProject(
>
> projChild,Pair.left(newProjects),Pair.right(newProjects),false,relBuilder);
>
> Reporter: HULING
> Assignee: Julian Hyde
> Priority: Minor
>
> PushProjector.java (line 505)
> it name the field using the name of the operators , for example, "*" for
> MULTIPLY.
> But,the field with name "*" usually has speciall means.
> I suggest not to use the name of the operators .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
