[
https://issues.apache.org/jira/browse/CALCITE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354858#comment-16354858
]
Shuyi Chen commented on CALCITE-2171:
-------------------------------------
I see, do we leave it there just for demonstration purpose? But it's confusing
though when I was reading the code. I would suggest clone the test to both use
SPI and model.json file. Otherwise, if ModelHandler.addFunctions breaks, we
wont be able to catch it. But maybe there are other tests testing the code path
that I am unaware of. What do you think?
> ExampleFunctionTest is not reading model.json
> ----------------------------------------------
>
> Key: CALCITE-2171
> URL: https://issues.apache.org/jira/browse/CALCITE-2171
> Project: Calcite
> Issue Type: Bug
> Reporter: Shuyi Chen
> Assignee: Shuyi Chen
> Priority: Major
>
> ExampleFunctionTest is not reading model.json at all. I think we can either
> remove it, or modify the code to read model.json. Please let me know.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
