# [jira] [Comment Edited] (CALCITE-2190) Extend SubstitutionVisitor.splitFilter to cover different order of operands

```    [
https://issues.apache.org/jira/browse/CALCITE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373832#comment-16373832
] ```
```
Jesus Camacho Rodriguez edited comment on CALCITE-2190 at 2/23/18 2:38 AM:
---------------------------------------------------------------------------

[~julianhyde], could you review https://github.com/apache/calcite/pull/635 ? It
is not a complete solution by any means, but it will help us solving the most
common cases. Thanks

was (Author: jcamachorodriguez):
[~julianhyde], could you review https://github.com/apache/calcite/pull/635 ? It
is not a complete solution by any means, but it will help us solving the most
common cases.

> Extend SubstitutionVisitor.splitFilter to cover different order of operands
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-2190
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2190
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>
> {{SubstitutionVisitor.splitFilter}} does structural comparison to identify
> relevant predicates. The method could sort the operands for some expressions
> in a deterministic way to maximize possible matches.
> For instance, currently this example yields correct results:
> {code}
> condition: x = 1 or y = 2
> target:    y = 2 or x = 1
> -> residue:   true
> {code}
> However, the following equivalent example fails:
> {code}
> condition: x = 1 or y = 2
> target:    y = 2 or 1 = x
> {code}

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
```